Multi-Project-Extension #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After V0.30 was released the code, that was initially sumbmitted for PR#221 got corrupted. Revamped the branch and fixed the code.
modos189
requested changes
Jan 16, 2020
Various smaller cosmetic changes in Bookmarks only SYNC default Namespace
BM - highlights and markes follow the changed project. - sync will only act on default storage. - typos fixed MPE - removed debug code
|
In the first commit I fixed the syntax, and in the second I removed the font-awesome. Why? In the task #236 we discussed the use of icons - they should be font or svg. Also note https://github.com/IITC-CE/ingress-intel-total-conversion/pull/312/files#diff-3073581708df23c3f1bd259521cb3021R8. |
|
Syntax changes are ok, while I prefer way more comments and explanations to each function. The dividers between the functions helped a lot to reverse engineer the code. But this is a different discussion. FontAwesome: the current usage of SVGs already have negative side effects in some faction specific plugins, esp. if combined with "alternative text". But that is a different discussion too. |
modos189
approved these changes
Feb 18, 2020
…rsion into Multi-Project-Extension � Conflicts: � plugins/draw-tools.js
MysticJay
added a commit
to MysticJay/ingress-intel-total-conversion
that referenced
this pull request
Jul 16, 2020
Changing default behavour to merge. This is more intuitive as it matches windows' "paste". furthermore the user has to actively disable merge to avoid accidential overwrite by paste. (PR obeys changes in IITC-CE#312 and can be merged to master in any order)
Closed
MysticJay
added a commit
to MysticJay/ingress-intel-total-conversion
that referenced
this pull request
Jul 20, 2020
basic changes to keep compatibility with IITC-CE#312 and IITC-CE#375
MysticJay
added a commit
to MysticJay/ingress-intel-total-conversion
that referenced
this pull request
Jul 20, 2020
Added all EDF related code from Draw Tools plus to Drawtools. WIP-code from DTplus skipped fixed indentation OK to pull with IITC-CE#312 (MPE) and IITC-CE#375 (Merge) in any order
modos189
pushed a commit
to MysticJay/ingress-intel-total-conversion
that referenced
this pull request
Dec 28, 2020
basic changes to keep compatibility with IITC-CE#312 and IITC-CE#375
modos189
pushed a commit
to MysticJay/ingress-intel-total-conversion
that referenced
this pull request
Dec 28, 2020
Added all EDF related code from Draw Tools plus to Drawtools. WIP-code from DTplus skipped fixed indentation OK to pull with IITC-CE#312 (MPE) and IITC-CE#375 (Merge) in any order
MysticJay
added a commit
to MysticJay/ingress-intel-total-conversion
that referenced
this pull request
Apr 11, 2021
Added all EDF related code from Draw Tools plus to Drawtools. WIP-code from DTplus skipped fixed indentation OK to pull with IITC-CE#312 (MPE) and IITC-CE#375 (Merge) in any order
MysticJay
added a commit
to MysticJay/ingress-intel-total-conversion
that referenced
this pull request
Jul 13, 2021
Added all EDF related code from Draw Tools plus to Drawtools. WIP-code from DTplus skipped fixed indentation OK to pull with IITC-CE#312 (MPE) and IITC-CE#375 (Merge) in any order
modos189
added a commit
that referenced
this pull request
Jul 23, 2022
* Code for Empty Drawn Fields (EDF) added Added all EDF related code from Draw Tools plus to Drawtools. WIP-code from DTplus skipped fixed indentation OK to pull with #312 (MPE) and #375 (Merge) in any order * Copy Dialog Extend Copy dialog to allow copying polylines too * CSSsetup removed Unused Code removed. Not related to EDF. * Resolve Conflicts manual conflict resolution. code style : long lines * Indentation Adjusting Indentation * Dialog Size copy dialog too high * Code Style new code should not trigger eslint * EDF namespace removed removed edf sub-namespace and integrated to drawTools namespace Co-Authored-By: ZasoGD <[email protected]> * Inteactivity interactive toggles now with visibility of filling * DeleteStart-Stop show reactivate interactivity and filling when starting to delete Objects * CSS fixes DToptions dialog without special styles * fixup typo Co-authored-by: ZasoGD <[email protected]> Co-authored-by: Alexander Danilov <[email protected]>
xscreach
pushed a commit
to xscreach/ingress-intel-total-conversion
that referenced
this pull request
Aug 10, 2022
* Code for Empty Drawn Fields (EDF) added Added all EDF related code from Draw Tools plus to Drawtools. WIP-code from DTplus skipped fixed indentation OK to pull with IITC-CE#312 (MPE) and IITC-CE#375 (Merge) in any order * Copy Dialog Extend Copy dialog to allow copying polylines too * CSSsetup removed Unused Code removed. Not related to EDF. * Resolve Conflicts manual conflict resolution. code style : long lines * Indentation Adjusting Indentation * Dialog Size copy dialog too high * Code Style new code should not trigger eslint * EDF namespace removed removed edf sub-namespace and integrated to drawTools namespace Co-Authored-By: ZasoGD <[email protected]> * Inteactivity interactive toggles now with visibility of filling * DeleteStart-Stop show reactivate interactivity and filling when starting to delete Objects * CSS fixes DToptions dialog without special styles * fixup typo Co-authored-by: ZasoGD <[email protected]> Co-authored-by: Alexander Danilov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After V0.30 was released the code, that was initially sumbmitted for PR#221 got corrupted.
Revamped the branch and fixed the code.