Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: layers: add a 20m range around portals, to aid Wayfarer submissions #785

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

sandrotosi
Copy link
Contributor

Currently submitting a new portals that's closer than 20 meters to an existing one, will not make it appear on the map even if accepted.

In order to facilitate the submission of new portals, let's draw a 20m range around portals, making the un-shaded area available for new submissions.

Copy link

github-actions bot commented Nov 25, 2024

🤖 Pull request artifacts

file commit
IITC_Mobile-test.apk 49856e2
test-0.39.1.20241125.080443.zip 49856e2

See build on website

…ions

Currently submitting a new portals that's closer than 20 meters to an existing
one, will not make it appear on the map even if accepted.

In order to facilitate the submission of new portals, let's draw a 20m range
around portals, making the un-shaded area available for new submissions.
@sandrotosi sandrotosi force-pushed the wayfarer-range-plugin branch from b93539a to 49856e2 Compare November 25, 2024 08:04
@xscreach
Copy link
Contributor

Is this true? Afaik new portals respect S2 cell of some level (can't remember which) but thanks to that it's possible to submit portals way closer than 20m, they just need to NOT share the S2 cell 🤔

@xscreach
Copy link
Contributor

Is this true? Afaik new portals respect S2 cell of some level (can't remember which) but thanks to that it's possible to submit portals way closer than 20m, they just need to NOT share the S2 cell 🤔

Ok, edits don't respect this, but new nominations do 👍

@sandrotosi
Copy link
Contributor Author

Is this true? Afaik new portals respect S2 cell of some level (can't remember which) but thanks to that it's possible to submit portals way closer than 20m, they just need to NOT share the S2 cell 🤔

Ok, edits don't respect this, but new nominations do 👍

yeah that's the information i have: for a new POI you need to stay away 20m from others, while you can move an existing POI closer than that.

im curious what an S2 cell is tho, can you share some info? thanks!

@xscreach
Copy link
Contributor

@sandrotosi well, there are these cells... these red ones are for ingress, the blue ones for pogo... and it was said that only one portal (or pokestop/gym) can be inside of a cell... but I'm not sure how that works these days with the 20m rule 🤷‍♂️

SmartSelect_20241125_192141_IITC Mobile Beta.png

https://raw.githubusercontent.com/IITC-CE/Community-plugins/master/dist/DanielOnDiordna/cells.user.js

@sandrotosi
Copy link
Contributor Author

do you know how to access objects created by another plugin? namely the draw tools in this case?

it would be interesting to be able to "Draw a marker" on the map and get the same 20m radius around it, when "wayfarer range" is selected

@modos189
Copy link
Contributor

@sandrotosi I think such this plugin is a good example. It also takes data from Draw tools:
https://github.com/IITC-CE/ingress-intel-total-conversion/blob/master/plugins/done-links.js#L69

@modos189 modos189 merged commit 738472d into IITC-CE:master Dec 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants