Support DATABASE_CACERTFILE
#22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also change to use the official image from GitHub's container registry, as encouraged in the docs. Signed-off-by: Martin Haug <[email protected]>
Signed-off-by: Martin Haug <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for the new
DATABASE_CACERTFILEenvironment variable (Plausible 2.1.2 and later) by allowing a user to add a trusted root certificate for their database in the values file. This certificate will be stored in a secret and mounted as a volume if set. This is needed because root certificate checks are now enforced but the container is built with an empty / unused trust store. Hence, if connecting to Postgres via TLS, this configuration must be provided.The PR also updates Plausible to 2.1.4.
Which issue this PR fixes
Allows the user to connect to a database via TLS on Plausible 2.1.2 and later. Can help #10 and #17 because üroviding
DATABASE_CACERTFILEforces a connection using TLS/SSL and supersedes the?ssl=trueconnection string parameter. However, it's not a fix because parameters will still not have an effect on that container and prevent its startup.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]