Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md.jinja2, fixing broken link #949

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

cmungall
Copy link
Contributor

@cmungall cmungall commented Nov 1, 2023

The previous link was a 404. I think this is the best replacement.

Coordinated issues:

The previous link was a 404. I think this is the best replacement.

Coordinated issues:

- linkml/linkml-project-cookiecutter#77
cmungall added a commit to OBOAcademy/obook that referenced this pull request Nov 1, 2023
I think we need more guidance on what makes a good PR (atomic, don't mix concerns, etc), distinct from the mechanics. I added links to the top for now.

see also:

- INCATools/ontology-development-kit#949
- linkml/linkml-project-cookiecutter#77
matentzn pushed a commit to OBOAcademy/obook that referenced this pull request Nov 2, 2023
I think we need more guidance on what makes a good PR (atomic, don't mix concerns, etc), distinct from the mechanics. I added links to the top for now.

see also:

- INCATools/ontology-development-kit#949
- linkml/linkml-project-cookiecutter#77
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cmungall

@matentzn matentzn merged commit 050da01 into master Nov 2, 2023
1 check passed
@matentzn matentzn deleted the cmungall-patch-1 branch November 2, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants