Fix Issue#144 安卓版 Key 的暂停 Bug #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memorydream
reviewed
Mar 16, 2024
Comment on lines
+93
to
+97
| public void ResetTouch() | ||
| { | ||
| isTouchDown = false; | ||
| Dispatch(InputType.Up); | ||
| } |
There was a problem hiding this comment.
Dispatch 是通过消息总线，以事件的方式直接发送到 note clip，并直接响应
直接派发消息看上去会导致 note 暂停时错误的判断 input 状态
memorydream
approved these changes
Mar 28, 2024
Chen-Luan
pushed a commit
that referenced
this pull request
Oct 26, 2024
* Fix Issue#144 安卓版 Key 的暂停 Bug * Add TODO TODO: 统一输入行为后重构相关逻辑
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复了Issue#144中的Bug