Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to determining JSON directory location. #519

Closed
wants to merge 1 commit into from

Conversation

ptth222
Copy link

@ptth222 ptth222 commented Jan 19, 2024

If you run a program from the same directory that the JSON file is located in and use a relative path to create the file object, then the "name" property will only return the name of the file and you won't be able to parse the directory the file is in, which results in an error. I have changed the code to use the pathlib library to first resolve the file object name property into a full path and use the parent property to get the directory it is in.

@proccaserra
Copy link
Member

@ptth222 thanks for the PR! while this is distinct from issue #516 it affects the same function. @terazus let's have a look at this

@terazus
Copy link
Collaborator

terazus commented Mar 1, 2024

This should be mergeable once #511 is merged.

@terazus terazus closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants