Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes all the way back to the initial meeting we had to discuss adding a way to opt out of the configuration validations. I have implemented that here. A "no_config" parameter was added to both the JSON and Tab validation and propagated appropriately so configuration validation can be optional. There are also a few messaging changes and some slight fixes.
One issue I found during testing was that some of the rules in the Tab validate have lines like
result = result and func()
. This essentially makes it to where the func() won't run after 1 error or warning is found. This eliminates some warnings or errors from being repeated multiple times, but also hides when there are multiple different ones at the same time. "test_b_ii_s_3" in "isatab/validate/test_core.py" is a good example. There are 2 different columns with warnings, but before this change you only saw 1 of those warnings, but those 2 warnings are repeated for each row. I'm not sure what would be the preference for how to handle this. I thought that maybe before issuing the warning there could be a check to see if the exact same warning was already issued and not do it again, but implementing this in a robust way did not seem trivial. For now, I simply left it so that the warnings/errors are repeated and changed the tests to match that where necessary.