Ticket8329jenkins

[danielmaclaren]

Description of work

Removed exsisting checks for folders without '-' as these have been removed

Ticket

Link to Ticket

Acceptance criteria

Creation of Builds all follow the same format "BUILD-####"

---

Code Review

• Is the code of an acceptable quality?
• If the change is to an OPI, does the check_opi_format.py script in C:\Instrument\Dev\ibex_gui\base\uk.ac.stfc.isis.ibex.opis pass?
• Do the changes function as described and is it robust?
• Is there associated PR for the release notes?

Final Steps

• Reviewer has also merged the release notes

[Tom-Willemsen]

• I think we need to adjust the install script here:

  ibex_utils/installation_and_upgrade/IBEX_upgrade.py

  Line 137 in 37183bb

  DIRECTORIES["Client"] = FileUtils.get_latest_directory_path(client_build_dir, "BUILD")

• If we want VHD builds to follow this convention too then we need to adjust

  ibex_utils/installation_and_upgrade/ibex_install_utils/tasks/vhd_tasks.py

  Line 195 in 37183bb

  build_folder = os.path.join(REMOTE_VHD_DEST_DIR, "Builds", "Build{}".format(os.environ["BUILD_NUMBER"]))

[danielmaclaren]

@Tom-Willemsen

Thanks for point that out! I've update the two mentioned lines as well as checked for any other "BUILD" within the ibex_utils folder.

Would you like to rerun the jenkins test before pushing this through to review again?

Thanks!