Merge pull request #37 from inwoo-park/simba

CHG: Fix default value for decreasing downward longwave radiation with a value of 29 W m-2 km-1.
ISSMteam · Dec 30, 2024 · f0bc170 · f0bc170
2 parents 002427c + 49d92f6
commit f0bc170
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/src/c/classes/Elements/Element.cpp b/src/c/classes/Elements/Element.cpp
@@ -4851,7 +4851,8 @@ void       Element::SmbSemicTransient(){/*{{{*/
 		}
 
 		/* downward longwave radiation correction (Marty et al. 2002) */
-		st[iv]=(s[iv]-s0gcm[iv])/1000.;
+        /* Unit of "md.smb.rdl" is defined in W m-2 km-1 */
+		st[iv]=(s[iv]-s0gcm[iv])/1000.; /* unit in km */
 		dailydlradiation[iv]=dailydlradiation[iv]+rdl*st[iv];
 	}
 	if(isverbose && this->Sid()==0){

diff --git a/src/m/classes/SMBsemic.m b/src/m/classes/SMBsemic.m
@@ -159,9 +159,9 @@
 			self.rcrit = 0.85; % from Krapp et al. (2017)
 
 			self.desfac		      = -log(2.0)/1000;
-			self.desfacElevation = 2000;
+			self.desfacElevation  = 2000;
 			self.rlaps		      = 7.4;
-			self.rdl			      = 0.29;
+			self.rdl			  = 29; % from  Marty et al. (2002)
 
 			self.ismethod        = 0;
 			self.requested_outputs={'default'};
@@ -235,7 +235,7 @@ function disp(self) % {{{
 			fielddisplay(self,'dailytemperature','daily surface air temperature [K]');
 			fielddisplay(self,'rlaps','present day lapse rate (default is 7.4 [degree/km]; Erokhina et al. 2017)');
 			fielddisplay(self,'desfac','desertification elevation factor (default is -log(2.0)/1000 [1/km]; Vizcaino et al. 2010)');
-			fielddisplay(self,'rdl','longwave downward radiation decrease (default is 0.29 [W/m^2/km]; Marty et al. 2002)');
+			fielddisplay(self,'rdl','longwave downward radiation decrease (default is 29 [W/m^2/km]; Marty et al. 2002)');
 			fielddisplay(self,'s0gcm','GCM reference elevation; (default is 0) [m]');
 
 			fielddisplay(self,'ismethod','method for calculating SMB with SEMIC. Default version of SEMIC is really slow. 0: steady, 1: transient (default: 0)');

diff --git a/src/m/classes/SMBsemic.py b/src/m/classes/SMBsemic.py
@@ -92,7 +92,7 @@ def __repr__(self):  # {{{
         s += '{}\n'.format(fielddisplay(self, 'dailyairhumidity', 'daily air specific humidity [kg/kg]'))
         s += '{}\n'.format(fielddisplay(self, 'rlaps', 'present day lapse rate (default is 7.4 [degree/km]; Erokhina et al. 2017)'))
         s += '{}\n'.format(fielddisplay(self, 'desfac', 'desertification elevation factor (default is -log(2.0)/1000 [1/km]; Vizcaino et al. 2010)'))
-        s += '{}\n'.format(fielddisplay(self, 'rdl', 'longwave downward radiation decrease (default is 0.29 [W/m^2/km]; Marty et al. 2002)'))
+        s += '{}\n'.format(fielddisplay(self, 'rdl', 'longwave downward radiation decrease (default is 29 [W/m^2/km]; Marty et al. 2002)'))
         s += '{}\n'.format(fielddisplay(self, 's0gcm', 'GCM reference elevation; (default is 0) [m]'))
         s += '{}\n'.format(fielddisplay(self, 'ismethod','method for calculating SMB with SEMIC. Default version of SEMIC is really slow. 0: steady, 1: transient (default: 0)'))
         if self.ismethod: # transient mode
@@ -228,7 +228,7 @@ def setdefaultparameters(self):  #{{{
         self.desfac = -log(2.0) / 1000
         self.desfacElevation = 2000
         self.rlaps = 7.4
-        self.rdl = 0.29
+        self.rdl   = 29 # from Marty et al. (2002)
 
         self.ismethod = 0
         self.requested_outputs = ['default']