Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW: add "loadmodel_netcdf.py" in "src/m/contrib/inwoo" #36

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

inwoo-park
Copy link
Contributor

  • Enable to load ISSM model written in netcdf file using "src/m/contrib/defleurian/netCDF/export_netCDF.m".
  • Enable to load ISSM model using both matlab and python.

@TidbitSoftware
Copy link
Collaborator

Hi Inwoo,
Looks like the regression tests for Python are not passing. I'm happy to merge when they do. This will be a great contribution!

@inwoo-park
Copy link
Contributor Author

@TidbitSoftware

Is it my problem? Or just some mistakes in CI (Continuous Integration)?

@TidbitSoftware
Copy link
Collaborator

You know, I'm not completely sure what's going on with it because everything out side of the merge is passing in Jenkins. Looking into this further.

@TidbitSoftware
Copy link
Collaborator

Okay, I re-ran tests on another commit and they fail in the same spot. Working on this now and will accept your PR when I have it fixed.

@TidbitSoftware TidbitSoftware merged commit 5bb9734 into ISSMteam:main Dec 14, 2024
6 of 8 checks passed
@TidbitSoftware
Copy link
Collaborator

Hi Inwoo,
You were totally right: it was an issue with the most recent version of NumPy, but I mistakenly assumed it was your commit. I've merged it in now.

@inwoo-park
Copy link
Contributor Author

Hi @TidbitSoftware

It sounds good!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants