Added Codewars, TV and channels classes task and RPG Saga (feature complete) #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskonst
reviewed
Nov 12, 2023
| @@ -0,0 +1 @@ | |||
| node_modules | |||
There was a problem hiding this comment.
по идее gitignore выше должен ловить все node_modules
jskonst
reviewed
Nov 12, 2023
| new Channel('Cartoon Network'), | ||
| ]; | ||
|
|
||
| describe('Testing printing TV ASCII', () => { |
jskonst
reviewed
Nov 12, 2023
rpgsaga/saga/src/tv.ts
Outdated
| @@ -0,0 +1,97 @@ | |||
| export class Channel { | |||
| static chCount = -1; | |||
There was a problem hiding this comment.
это поле тогда надо делать приватным
jskonst
reviewed
Nov 12, 2023
| @@ -0,0 +1,33 @@ | |||
|
|
|||
jskonst
reviewed
Nov 12, 2023
rpgsaga/saga/src/tv.ts
Outdated
| @@ -0,0 +1,97 @@ | |||
| export class Channel { | |||
jskonst
reviewed
Nov 12, 2023
rpgsaga/saga/src/tv.ts
Outdated
Comment on lines
15
to
17
| static channels: Array<Channel>; | ||
| static noChannel = new Channel('No Channel'); | ||
| static tvAsciiParts: Array<string> = [ |
There was a problem hiding this comment.
не злоупотребляйте статическими полями - это почти глобальные переменные, которые могу привести к непредсказуемому поведению
jskonst
reviewed
Nov 12, 2023
rpgsaga/saga/src/tv.ts
Outdated
| static tvCount = 0; | ||
| static channels: Array<Channel>; | ||
| static noChannel = new Channel('No Channel'); | ||
| static tvAsciiParts: Array<string> = [ |
There was a problem hiding this comment.
в ts есть многострочная строка
jskonst
reviewed
Nov 12, 2023
rpgsaga/saga/src/tv.ts
Outdated
Comment on lines
38
to
41
| brand: string; | ||
| model: string; | ||
| serialNumber: string; | ||
| channel: Channel; |
jskonst
reviewed
Nov 12, 2023
|
|
||
| public printedTV(): string { | ||
| let channelAscii = ''; | ||
| if (this.channel.name.length <= 18) { |
There was a problem hiding this comment.
если что-то было передано не так, то как минимум в 1 месте бросьте exception
jskonst
reviewed
Nov 12, 2023
rpgsaga/saga/src/tv.ts
Outdated
| this.channel = Television.noChannel; | ||
| } | ||
|
|
||
| public printedTV(): string { |
There was a problem hiding this comment.
вот название не очень соответствует тому, что происходит внутри
This reverts commit bac7c0d.
…age, calculated through affinity system; lots of names added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.