[NDTensors] Fix output type of Empty BlockSparse contraction #1135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output type of Empty BlockSparse contraction was a bit off, and not adjusting for the dimensions of the output tensor. That caused some subtle bugs in other operations that were expecting the types to be the same, see:
ITensor/ITensorInfiniteMPS.jl#77 (comment)
EDIT: This also adds a definition for
Base.zero(T::ITensor)
, which makes it so that operations likeMatrix{ITensor} * Matrix{ITensor}
work (as matrix multiplication where the elements are ITensors that get contracted). That's helpful for MPO formats that are matrices of ITensors.@LHerviou @kmp5VT