-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move NDTensors
to a subdirectory to prepare for registering
#777
Conversation
Codecov Report
@@ Coverage Diff @@
## main #777 +/- ##
===========================================
- Coverage 67.10% 24.02% -43.09%
===========================================
Files 92 64 -28
Lines 10691 7364 -3327
===========================================
- Hits 7174 1769 -5405
- Misses 3517 5595 +2078
Continue to review full report at Codecov.
|
Some reference PRs from when Makie made this change: |
Benchmark resultJudge resultBenchmark Report for /home/runner/work/ITensors.jl/ITensors.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/ITensors.jl/ITensors.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/ITensors.jl/ITensors.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
For now this is simply a reorganization, but it is in preparation for going back to having
NDTensors
as a registered Julia package.The idea is that the code itself for
NDTensors
will live inside this repository, but it will be registered as it's own Julia package, which is possible as a result of some work to handle this use case from the side of Julia's package manager:Note this development workflow is used by some high profile packages like Makie and SnoopCompile, so things like CI, package registration, and development should be smooth and we can use those packages as inspiration for how to set things up.
Part of the goal is to test this out for
NDTensors
first and then move packages that are tightly coupled to the development of ITensors.jl into this repository, like:and also maybe consider splitting up the ITensors module into more pieces, for example spin off
ContractionSequenceOptimization
andLazyApply
into their own registered packages. This will make development easier, so we can immediately see if changes toITensors
affects these packages with CI and then update them all at once if needed.