Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boundary_partitionedges #51

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

JoeyT1994
Copy link
Contributor

New function boundary_partitionedges(pg::PartitionedGraph, partitionvertices::Vector{<:PartitionVertex}) which returns all the partitionedges (in PartitionEdge format) incoming to the region specified by partitionvertices. Tests are also added.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2dbd17) 78.68% compared to head (3c8f13e) 78.92%.
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   78.68%   78.92%   +0.23%     
==========================================
  Files          31       31              
  Lines        1187     1191       +4     
==========================================
+ Hits          934      940       +6     
+ Misses        253      251       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/NamedGraphs.jl Outdated Show resolved Hide resolved
@mtfishman mtfishman changed the title Boundary_partitionedges boundary_partitionedges Feb 22, 2024
@mtfishman
Copy link
Member

Could you add a test for copy(::PartitionedGraph)?

@JoeyT1994
Copy link
Contributor Author

Sure I just added that.

@mtfishman
Copy link
Member

Thanks!

@mtfishman mtfishman merged commit 749dc45 into ITensor:main Mar 6, 2024
10 of 11 checks passed
@JoeyT1994
Copy link
Contributor Author

Can we move to a new version of NamedGraphs following this PR? Just so the tests for the ITensorNetworks PR: ITensor/ITensorNetworks.jl#139 pass

@mtfishman
Copy link
Member

Thanks for the reminder, registering it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants