Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve namespacing #64

Merged
merged 19 commits into from
Apr 16, 2024
Merged

Improve namespacing #64

merged 19 commits into from
Apr 16, 2024

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Apr 15, 2024 •
edited
Loading

Improve namespacing by splitting up code into submodules, switching to explicit imports, etc.

TODO:

  • Get tests passing.
  • Remove imports and implicit using statements.
  • Remove most exports.
  • Create GraphGenerators and NamedGraphGenerators submodules.
  • Create Keys submodule.

@mtfishman mtfishman marked this pull request as draft April 15, 2024 21:57
github-actions[bot]
github-actions bot reviewed Apr 16, 2024
View reviewed changes
src/NamedGraphs.jl Outdated Show resolved Hide resolved
@mtfishman mtfishman changed the title [WIP] Improve namespacing Improve namespacing Apr 16, 2024
@mtfishman mtfishman marked this pull request as ready for review April 16, 2024 17:53
@mtfishman mtfishman merged commit 254e4cd into main Apr 16, 2024
8 of 9 checks passed
@mtfishman mtfishman deleted the namespaces branch April 16, 2024 17:59
This was referenced Apr 16, 2024
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mtfishman