WIP: Make join type left

The DependecyNodeSummary requires left joins to summarise all available rows, while the redundancy group joins nodes and edges as inner joins, which leads to false positives.
Icinga · Oct 9, 2024 · 6e591e2 · 6e591e2
1 parent 9506986
commit 6e591e2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/library/Icingadb/Model/DependencyEdge.php b/library/Icingadb/Model/DependencyEdge.php
@@ -62,8 +62,10 @@ public function createRelations(Relations $relations): void
 
         // "from" and "to" are only necessary for sub-query filters.
         $relations->belongsTo('from', DependencyNode::class)
-            ->setCandidateKey('from_node_id');
+            ->setCandidateKey('from_node_id')
+            ->setJoinType('LEFT');
         $relations->belongsTo('to', DependencyNode::class)
-            ->setCandidateKey('to_node_id');
+            ->setCandidateKey('to_node_id')
+            ->setJoinType('LEFT');
     }
 }
diff --git a/library/Icingadb/Model/RedundancyGroup.php b/library/Icingadb/Model/RedundancyGroup.php
@@ -65,10 +65,12 @@ public function createRelations(Relations $relations): void
         $relations->belongsToMany('from', DependencyEdge::class)
             ->setTargetCandidateKey('from_node_id')
             ->setTargetForeignKey('id')
-            ->through(DependencyNode::class);
+            ->through(DependencyNode::class)
+            ->setJoinType('LEFT');
         $relations->belongsToMany('to', DependencyEdge::class)
             ->setTargetCandidateKey('to_node_id')
             ->setTargetForeignKey('id')
-            ->through(DependencyNode::class);
+            ->through(DependencyNode::class)
+            ->setJoinType('LEFT');
     }
 }