fix2: Resolve review comments related to HasRootProblem behavior

Icinga · Oct 1, 2024 · d824e9a · d824e9a
1 parent d8a6fed
commit d824e9a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/application/controllers/ServiceController.php b/application/controllers/ServiceController.php
@@ -41,12 +41,12 @@ public function init()
         $query = Service::on($this->getDb())
             ->withColumns(['has_root_problem'])
             ->with([
-            'state',
-            'icon_image',
-            'host',
-            'host.state',
-            'timeperiod'
-        ]);
+                'state',
+                'icon_image',
+                'host',
+                'host.state',
+                'timeperiod'
+            ]);
         $query
             ->setResultSetClass(VolatileStateResults::class)
             ->filter(Filter::all(

diff --git a/library/Icingadb/Model/Behavior/HasRootProblem.php b/library/Icingadb/Model/Behavior/HasRootProblem.php
@@ -14,12 +14,15 @@
 use ipl\Orm\Contract\RewriteColumnBehavior;
 use ipl\Orm\Contract\QueryAwareBehavior;
 
+/**
+ * Behavior to check if the object has a root problem
+ */
 class HasRootProblem implements RewriteColumnBehavior, QueryAwareBehavior
 {
     /** @var Query */
     protected $query;
 
-    public function setQuery(Query $query)
+    public function setQuery(Query $query): self
     {
         $this->query = $query;
 
@@ -64,7 +67,7 @@ public function rewriteColumnDefinition(ColumnDefinition $def, string $relation)
     {
     }
 
-    public function rewriteCondition(Filter\Condition $condition, $relation = null)
+    public function rewriteCondition(Filter\Condition $condition, $relation = null): void
     {
         $column = substr($condition->getColumn(), strlen($relation));