Keep compatibility with Icinga DB v5 #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
force-pushed
the
use-singleton-for-db-and-redis-connections
branch
from
96e85db to
c57298e
Compare
nilmerg
force-pushed
the
ensure-compatiblity-with-db-schema-v5
branch
from
bad64e8 to
e43e81c
Compare
Base automatically changed from
use-singleton-for-db-and-redis-connections
to
dependencies
December 17, 2024 15:35
sukhwinder33445
force-pushed
the
ensure-compatiblity-with-db-schema-v5
branch
4 times, most recently
from
7d6b136 to
7ca1359
Compare
nilmerg
commented
Dec 18, 2024
sukhwinder33445
force-pushed
the
ensure-compatiblity-with-db-schema-v5
branch
from
7ca1359 to
87a203f
Compare
sukhwinder33445
force-pushed
the
ensure-compatiblity-with-db-schema-v5
branch
from
87a203f to
1ffbe35
Compare
yhabteab
reviewed
Jan 7, 2025
| ]; | ||
|
|
||
| if (Backend::getDbSchemaVersion() >= 6) { |
There was a problem hiding this comment.
Since Icinga DB 1.2.1 was released last year without any changes to dependencies, this should be updated to schema version 7 accordingly.
There was a problem hiding this comment.
@sukhwinder33445 Please do so.
There was a problem hiding this comment.
Btw. The used schema version isn't the same for both supported DBMs, i.e. current MySQL schema version is 6, while for PostgreSQL, it is 4. Is this distinction not relevant in this context?
There was a problem hiding this comment.
Ups, yes, it is relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked by #1112