Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/go.mod: bump github.com/icinga/icinga-testing "version" #696

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

Al2Klimov
Copy link
Member

@Al2Klimov Al2Klimov added this to the 1.1.2 milestone Mar 14, 2024
@cla-bot cla-bot bot added the cla/signed label Mar 14, 2024
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not only bump github.com/icinga/icinga-testing, but almost every other package, too. However, those are not necessary being updated to their latest version. For example, go.uber.org/zap went from v1.21.0 to v1.26.0, while v1.27.0 is available, #680. Thus, maybe you just want to add another round of go get -u ./...?

Otherwise, the tests went through on my machine.

@Al2Klimov
Copy link
Member Author

In contrast, I think github.com/icinga/icinga-testing should be dependabotted.

@julianbrost
Copy link
Contributor

What exactly does that mean? #695 will enable dependabot for /tests, I don't know if that will be enough, or if it can be configured to track a branch, or if that means we'd have to tag every merge commit in the icinga-testing repo.

Anyways, so far, I haven't merged #695 as it might result in PRs being created that would directly become obsoleted by this PR if it updates other dependencies as well.

IMHO, this PR should either update just icinga-testing or everything in /tests, not something in between. I have a slight preference towards just icinga-testing as that will be trivial to review and therefore should fix the GitHub Actions more quickly.

Copy link
Contributor

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version bump of icinga-testing also includes Icinga/icinga-testing#26. Thus, this PR is actually the minimal change to do that bump as it all other module updates just reflect the changed dependencies of icinga-testing.

@julianbrost julianbrost merged commit f44c47e into main Mar 18, 2024
31 checks passed
@julianbrost julianbrost deleted the icinga-testing-503 branch March 18, 2024 09:33
@oxzi oxzi added the dependencies Pull requests that update a dependency file label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants