Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResultSet: Remove manual seek() call for php 5.6 support #141

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

sukhwinder33445
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 commented Jan 9, 2025

As we no longer support php 5.6, this can be removed.

It causes the following error when creating root problem path with the dependencies web module:
Screenshot 2025-01-09 at 11 26 45

@sukhwinder33445 sukhwinder33445 self-assigned this Jan 9, 2025
@cla-bot cla-bot bot added the cla/signed label Jan 9, 2025
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explained elsewhere why you don't need this change at all.

I'll merge this only for one reason: PHP 7.2+ does not need it.

@nilmerg nilmerg merged commit a26d9ae into main Jan 13, 2025
22 checks passed
@nilmerg nilmerg deleted the remove-obsolete-code branch January 13, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants