Str::symmetricSplit(): Make $default only accept string or null

After all, it is a Str-based class that should not pad anything other than string or null. see: https://github.com/Icinga/icingaweb2-module-businessprocess/actions/runs/8466543979/job/23195516401?pr=446
Icinga · Apr 22, 2024 · 4b797d5 · 4b797d5
1 parent e27166e
commit 4b797d5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Str.php b/src/Str.php
@@ -54,11 +54,11 @@ public static function startsWith(?string $subject, string $start, bool $caseSen
      * @param ?string $subject
      * @param string $delimiter
      * @param int    $limit
-     * @param mixed  $default
+     * @param ?string $default
      *
-     * @return array<int, mixed>
+     * @return array<int, ?string>
      */
-    public static function symmetricSplit(?string $subject, string $delimiter, int $limit, $default = null)
+    public static function symmetricSplit(?string $subject, string $delimiter, int $limit, ?string $default = null)
     {
         if ($subject === null || empty($delimiter)) {
             return array_pad([], $limit, $default);

diff --git a/tests/StrTest.php b/tests/StrTest.php
@@ -54,7 +54,7 @@ public function testSymmetricSplitReturnsArrayPaddedToTheSizeSpecifiedByLimitUsi
 
     public function testSymmetricSplitReturnsArrayPaddedToTheSizeSpecifiedByLimitUsingCustomValue()
     {
-        $this->assertSame(['foo', 'bar', false, false], Str::symmetricSplit('foo,bar', ',', 4, false));
+        $this->assertSame(['foo', 'bar', 'default', 'default'], Str::symmetricSplit('foo,bar', ',', 4, 'default'));
     }
 
     public function testSymmetricSplitReturnsUnpaddedArrayIfTheSizeOfTheExplodedStringIsLessThanLimit()