Consider special cases when comparing filter rules

Icinga · Mar 18, 2024 · 5d59f95 · 5d59f95
1 parent e15a8cf
commit 5d59f95
Show file tree

Hide file tree

Showing 4 changed files with 68 additions and 0 deletions.
diff --git a/src/Filter/Equal.php b/src/Filter/Equal.php
@@ -28,4 +28,21 @@ public function ignoresCase()
     {
         return $this->ignoreCase;
     }
+
+    public function sameAs(Rule $rule): bool
+    {
+        if (! $rule instanceof static) {
+            return false;
+        }
+
+        if ($this->ignoresCase() !== $rule->ignoresCase()) {
+            return false;
+        }
+
+        if (is_array($this->value)) {
+            return array_diff($this->value, (array) $rule->getValue()) === [];
+        }
+
+        return parent::sameAs($rule);
+    }
 }
diff --git a/src/Filter/Like.php b/src/Filter/Like.php
@@ -28,4 +28,21 @@ public function ignoresCase()
     {
         return $this->ignoreCase;
     }
+
+    public function sameAs(Rule $rule): bool
+    {
+        if (! $rule instanceof static) {
+            return false;
+        }
+
+        if ($rule->ignoresCase() !== $this->ignoresCase()) {
+            return false;
+        }
+
+        if (is_array($this->value)) {
+            return array_diff($this->value, (array) $rule->getValue()) === [];
+        }
+
+        return parent::sameAs($rule);
+    }
 }
diff --git a/src/Filter/Unequal.php b/src/Filter/Unequal.php
@@ -28,4 +28,21 @@ public function ignoresCase()
     {
         return $this->ignoreCase;
     }
+
+    public function sameAs(Rule $rule): bool
+    {
+        if (! $rule instanceof static) {
+            return false;
+        }
+
+        if ($this->ignoresCase() !== $rule->ignoresCase()) {
+            return false;
+        }
+
+        if (is_array($this->value)) {
+            return array_diff($this->value, (array) $rule->getValue()) === [];
+        }
+
+        return parent::sameAs($rule);
+    }
 }
diff --git a/src/Filter/Unlike.php b/src/Filter/Unlike.php
@@ -28,4 +28,21 @@ public function ignoresCase()
     {
         return $this->ignoreCase;
     }
+
+    public function sameAs(Rule $rule): bool
+    {
+        if (! $rule instanceof static) {
+            return false;
+        }
+
+        if ($rule->ignoresCase() !== $this->ignoresCase()) {
+            return false;
+        }
+
+        if (is_array($this->value)) {
+            return array_diff($this->value, (array) $rule->getValue()) === [];
+        }
+
+        return parent::sameAs($rule);
+    }
 }