Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Django 4.0 compatibility #317

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Added Django 4.0 compatibility #317

merged 2 commits into from
Nov 23, 2021

Conversation

g-as
Copy link
Contributor

@g-as g-as commented Nov 17, 2021

Resolves #315

@g-as
Copy link
Contributor Author

g-as commented Nov 17, 2021

@peppelinux

I did not put this branch on top of #292 since it will probably be easier to merge this and rebase the other branch.

@peppelinux
Copy link
Member

great job, can we also add a section on the official doc where explain the usage of signals?

@g-as
Copy link
Contributor Author

g-as commented Nov 17, 2021

Indeed, but it might be better suited in #292, since I haven't found any actual use of the 2 defined signals in the current codebase.

@g-as
Copy link
Contributor Author

g-as commented Nov 23, 2021

@peppelinux bumped django to 4.0 RC1

@peppelinux peppelinux merged commit 3a12949 into IdentityPython:master Nov 23, 2021
@g-as
Copy link
Contributor Author

g-as commented Nov 23, 2021

👍

@g-as g-as deleted the feature/django4.0 branch November 23, 2021 14:49
@g-as g-as mentioned this pull request Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signal's providing_args removal in 4.0
2 participants