Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update to latest actions version and base image #752

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

aperezdc
Copy link
Member

SSIA 😉

@aperezdc aperezdc added the enhancement New feature or request label Feb 12, 2025
@aperezdc aperezdc self-assigned this Feb 12, 2025
Try using newer version of clang-format-diff, as there has been many new
releases since the last time the script was updated.
@aperezdc aperezdc force-pushed the aperezdc/ci-updates branch 2 times, most recently from 4f5b501 to fe7894d Compare February 12, 2025 15:51
@@ -13,12 +13,16 @@ on:

jobs:
build:
# TODO: It would be nice to move away from Ubuntu 22.04, but that would
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The webkit-container-sdk is a 24.04 image with the dependencies :)

Can make an image based on it with webkit built.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we could but GitHub self-hosted runners won't take an arbitrary image. That would mean switching over to our own runner, so I would rather do it in separately.

@aperezdc aperezdc merged commit 88749bd into master Feb 13, 2025
5 checks passed
@aperezdc aperezdc deleted the aperezdc/ci-updates branch February 13, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants