Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpewebkit: Add a patch to fix LBSE blurriness #20

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

obyknovenius
Copy link
Collaborator

No description provided.

@psaavedra
Copy link
Member

Where this patch comes from? is there a PR related in WebKit?

@obyknovenius
Copy link
Collaborator Author

Where this patch comes from? is there a PR related in WebKit?

TL;DR: This patch is from me. There is no PR in WebKit because this is a hack and not a proper fix.

I've got this demo https://pastebin.igalia.com/pastebin.php?show=f2832cd0b from @nikolaszimmermann, demonstrating the progress on LBSE in WebKit. But when I tried it on RPi3 I noticed that it's blurry when with LBSE on:
blurry

After investigating it a bit I came up with this hack. While it's not a good solution it fixes the problem and the result looks much better:
crispy

Ignore the absence of the building on the second screenshot. It's unrelated to this patch.

@nikolaszimmermann
Copy link
Member

Hmmm we should really find the root cause.. you are already in the right code section, there is special code for LBSE to compute the scaling factor - did you check that?

@obyknovenius
Copy link
Collaborator Author

Hmmm we should really find the root cause.. you are already in the right code section, there is special code for LBSE to compute the scaling factor - did you check that?

I plan to investigate it further and find an appropriate fix. But now we need to get something ready for the demo.

@psaavedra
Copy link
Member

I've tested this patch in a RPI5. The blurry effect is present even with the patch:

Sharp (LBSE deactivated):

lbse_off

Very Blurry (not patch applied):

lbse_on_without_patch

Still a bit Blurry (patch applied):

I bit hard to appreciate but the image looks a bit pixelated

lbse_on

@psaavedra
Copy link
Member

I'm gonna go ahead and integrate this, even though it's not flawless. It'll still boost results with LBSE on.

@psaavedra psaavedra merged commit 393af37 into main-next Apr 17, 2024
1 of 2 checks passed
@obyknovenius obyknovenius deleted the vitaly/fix-lbse-blurriness branch April 17, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants