Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pid capability #1

Open
wants to merge 55 commits into
base: master
Choose a base branch
from
Open

Commits on Oct 19, 2022

  1. Configuration menu
    Copy the full SHA
    9636c6d View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. Configuration menu
    Copy the full SHA
    0a24679 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Fix build for HTML changes (w3c#1704)

    This does just enough to make the build pass for the navigable changes
    in HTML, without actually fixing the underlying model to match.
    
    Co-authored-by: Julian Descottes <[email protected]>
    jgraham and juliandescottes authored Dec 16, 2022
    Configuration menu
    Copy the full SHA
    7ba715f View commit details
    Browse the repository at this point in the history
  2. Node cache (w3c#1705)

    For WebDriver BiDi we want to be able to return any Node object, and
    to support all reachable Nodes, not just those in the same browsing
    context. Therefore the approach of having per-Window Element and
    ShadowRoot caches won't work. Instead implement the following:
    
    * A per session, per browsing context group Node to id mapping that
    can store any Node.
    * Frontends in WebDriver to store Elements and ShadowRoots in this
    map, and perform the additional same-document, connected element,
    checks that the protocol requires.
    
    This doesn't introduce any normative changes into WebDriver, it just
    refactors the infrastructure to make it reusable in the BiDi context.
    
    Co-authored-by: Maksim Sadym <[email protected]>
    jgraham and sadym-chromium authored Dec 16, 2022
    Configuration menu
    Copy the full SHA
    6c3b67a View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. Replace misleading term (w3c#1710)

    Use "error value" rather than the incorrect "error response".
    jugglinmike authored Jan 5, 2023
    Configuration menu
    Copy the full SHA
    02fe194 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. Fix returning stale element reference (w3c#1707)

    If we've previously seen an element in the current window, but it was
    GC'd we should return "stale element reference". To support this, add
    a set of seen node ids keyed on window so we can check if the element
    reference was ever valid in this document.
    jgraham authored Jan 6, 2023
    Configuration menu
    Copy the full SHA
    2ced487 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    714bd27 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2023

  1. Support different viewport origin representations

    This is really designed for BiDi, allowing actions to specify the
    origin relative to an element in the form:
    
     {
      type: "element"
      sharedId: <id>
     }
    
    rather than sending in a WebDriver-style element reference. 
    To use this, each caller has to pass in steps to determine if something
    represents an element origin, and if so, decode it into an actual element.
    
    This allows BiDi to specify different steps to WebDriver classic
    jgraham authored Jan 13, 2023
    Configuration menu
    Copy the full SHA
    3eec59b View commit details
    Browse the repository at this point in the history
  2. Separate out existence check of element and shadow root nodes from st…

    …aleness check.
    whimboo authored and jgraham committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    80b6d5d View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Configuration menu
    Copy the full SHA
    52f2d53 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Remove extra dash in w3c working group name (w3c#1716)

    Signed-off-by: Aurélien Pupier <[email protected]>
    apupier authored Feb 22, 2023
    Configuration menu
    Copy the full SHA
    883ea38 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2023

  1. Fix typos in algorithm for Element Send Keys (w3c#1721)

    Correct the markup so the build system recognizes the reference to the
    variable named "keyup action" and add a period to end the statement.
    jugglinmike authored Mar 3, 2023
    Configuration menu
    Copy the full SHA
    a638d46 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Configuration menu
    Copy the full SHA
    231c5fb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a65f9fb View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Configuration menu
    Copy the full SHA
    441e433 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Fix link for page loading strategy (w3c#1752)

    The existing link was self-referential.  This was unhelpful for understanding the document.
    Tommy G authored Aug 4, 2023
    Configuration menu
    Copy the full SHA
    866fedb View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. editorial: Use "content navigable" instead of "nested navigable" (w3c…

    …#1750)
    
    The term was renamed in the HTML spec in whatwg/html#8712 so the current
    reference was broken as mentioned in w3c#1735.
    
    While here, use ReSpec's shorthand syntax to refer to these sub concepts
    directly and avoid having to specifically link to them in the index at the
    end of the document.
    rakuco authored Aug 7, 2023
    Configuration menu
    Copy the full SHA
    e64e2c8 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Point Apple Safari Vendor status to W3C WebDriver protocol supported …

    …commands (w3c#1757)
    
    In this commit we update the Safari vendor status document to point to the set of commands supporting the W3C WebDriver protocol. The previous link redirects to [macOS WebDriver Commands for Safari 11.1 and earlier](https://developer.apple.com/documentation/webkit/macos_webdriver_commands_for_safari_11_1_and_earlier?language=objc), which highlights the WebDriver Commands supporting the Selenium JSON Wire Protocol instead.
    
    Signed-off-by: Abrar Rahman Protyasha <[email protected]>
    aprotyas authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    d9be1ae View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Raise "unsupported operation" error when "pointer" is used as origin …

    …for wheel input sources (w3c#1760)
    
    Move "pointer" check for wheel action into processing action step.
    
    This was previously leading to undefined behaviour in the spec, because a wheel input source doesn't have a location to offset from.
    whimboo authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    35a868a View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Fix "coordinates" typo in pointer input source description (w3c#1762)

    coordindates -> coordinates
    aprotyas authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    9da20e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Configuration menu
    Copy the full SHA
    ea8ff97 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Configuration menu
    Copy the full SHA
    cad2a23 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Configuration menu
    Copy the full SHA
    7366efb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e91f9d8 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Correct element click actions list (w3c#1779)

    * Correct element click actions list
    
    element click is erroneously defined as `«pointer move action, pointer down action, pointer move action».` but should obviously be `«pointer move action, pointer down action, pointer up action».` making use of the pointer up action defined
    
    * Correct element click pointer up action's id
    
    The pointer id of pointer up action should be "pointer" to match the pointer move and pointer down actions pointer ids
    dten authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    8e382d2 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Configuration menu
    Copy the full SHA
    2e6ca25 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Configuration menu
    Copy the full SHA
    9cb4450 View commit details
    Browse the repository at this point in the history
  2. Editorial: remove inaccurate qualifier

    This specification uses the List type from WHATWG Infra [1]. It does so
    indirectly, working with a derivative which it refers to as a "JSON
    List." This type is not defined, but because its usage matches that of
    the List, the qualifier "JSON" appears to be superfluous.
    
    Remove the qualifier to clarify the type of the specification values.
    
    [1] https://infra.spec.whatwg.org/#lists
    jugglinmike authored and jgraham committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    ec2663f View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Configuration menu
    Copy the full SHA
    d08a954 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Configuration menu
    Copy the full SHA
    0e8cc51 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Configuration menu
    Copy the full SHA
    a04dbf7 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Refactor session handling for better integration with BiDi (w3c#1608)

    With BiDi we want to support multiple sessions, at most one of which
    can also enable the HTTP frontend. Therefore we add the concept of
    multiple sessions, which can have different flags set according to the
    protocols they support (http, bidi, etc.).
    
    This explictly passes the session, parameters and url variables down
    into each command. In addition the URL variables are handled as a
    infra struct rather than as a custom thing with implied variables.
    
    Instead of having a concept of the "current session" we explicitly
    pass the session around where required.
    
    ---------
    
    Co-authored-by: Maksim Sadym <[email protected]>
    jgraham and sadym-chromium authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    63a397f View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Replace ' with &apos;

    This makes editing much easier, since unpaired ' were causing syntax highlighting
    problems.
    jgraham committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    dc7919e View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Configuration menu
    Copy the full SHA
    d05e463 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b7d581e View commit details
    Browse the repository at this point in the history
  3. Add a capability for returning the default user agent header value (w…

    …3c#1790)
    
    * Add userAgent capability
    
    * add userAgent to matching
    
    * Update index.html
    
    Co-authored-by: Henrik Skupin <[email protected]>
    
    ---------
    
    Co-authored-by: Henrik Skupin <[email protected]>
    OrKoN and whimboo authored Mar 7, 2024
    Configuration menu
    Copy the full SHA
    52c3e3a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    29d400a View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Fix unreferenced definitions

    This takes us down to zero respec warnings when bulding the spec.
    
    We still have terms which are only referenced in non-normative
    contexts. That's probably also a bug, and could be fixed in a
    followup. However this at least provides a clean baseline for future
    spec work.
    jgraham committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    44031be View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Fix timeouts configuration (w3c#1802)

    This refactors the way that timeout configuration is used in the spec,
    and fixes several bugs, but does not otherwise have intentional
    normative changes.
    
    The main change is the creation of a "timeouts configuration" struct
    that is owned by the session. A new struct is created when the
    timeouts are changed (including during capabilities processing) and
    this fixes a number of confusing cases where the "JSON deserialize"
    algorithm was linked in place of the more specific algorithm for
    reading the timeout data.
    
    In addition a new "timer" class is created with a flag that's set when
    the required time has elapsed. This is now used in all places where we
    wait up to a timeout, and we assume we're able to wait for the flag to
    change, or check the current value of the flag, as required. Fixing
    this required fixing many cases where it was assumed that timeouts
    couldn't be null.
    
    Co-authored-by: Alex Rudenko <[email protected]>
    Co-authored-by: Henrik Skupin <[email protected]>
    3 people authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    6c86972 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. User prompt handler capabilities (w3c#1791)

    Rewrite the user prompt handler configuration to allow overrides
    
    The idea is that for BiDi we'll accept objects like:
    
    {
      "alert": "dismiss",
      "beforeUnload": "ignore"
    }
    
    to allow different handling per prompt type, whilst falling back to
    the appropiate defaults to maintain the current behaviour for
    implementations that don't support BiDi.
    
    We also allow the possibility of multiple user prompts
    
    The specifications allow one prompt per event loop, so instead of
    assuming a single current user prompt, allow getting the user
    prompt for the active browsing context's event loop.
    
    ---------
    
    Co-authored-by: Henrik Skupin <[email protected]>
    jgraham and whimboo authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    43903d0 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Clarify when an element is disabled (w3c#1807)

    Selenium's atom "Is Element Enabled" special-cases the
    disabled state for "option" and "optgroup" elements
    when the nearest anchestor "select" is disabled as well.
    whimboo authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    98140ea View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Configuration menu
    Copy the full SHA
    d43acbb View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Bump Selenium revision to include fix for "Get Element Text" atom (w3…

    …c#1811)
    
    In SeleniumHQ/selenium@33c6b78
    the atom was fixed to correctly find capitalized text containing
    and underscore.
    whimboo authored May 8, 2024
    Configuration menu
    Copy the full SHA
    3b12477 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Configuration menu
    Copy the full SHA
    48a221b View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Configuration menu
    Copy the full SHA
    34f9efa View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Don't require user prompt handler notify to match when creating session

    This would prevent creating a BiDi session for a browser that already has a HTTP session
    with the notify flag set for some prompt handler.
    jgraham committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    0d759c9 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Configuration menu
    Copy the full SHA
    ebad903 View commit details
    Browse the repository at this point in the history
  2. Fixed parameter name in "Dispatch a pointerDown action" paragraph (w3…

    …c#1817) (w3c#1820)
    
    Incorrect parameter name "input state" was replaced with "source"
    
    Co-authored-by: daniilch <[email protected]>
    ChernyshevDS and daniilch authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    629163e View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Editorial: fix typo (w3c#1824)

    protcols -> protocols
    OrKoN authored Jul 1, 2024
    Configuration menu
    Copy the full SHA
    549d8aa View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Make object-valued user prompt handler defaults always override

    Previously an object value for the unhandledPromptBehavior capability
    like:
    
    {
      "default": "dismiss"
    }
    
    was equivalent to the string value
    
    "dismiss"
    
    which for legacy reasons does not affect "beforeUnload" prompts.
    
    For WebDriver-BiDi session we'd ideally like to remove this special
    case and have the default value apply to all prompt types.
    
    Therefore this changes things so that an object value with a default
    key provides a default that applies to all prompt types, whereas the
    traditional string values only apply to alert/confirm/prompt dialogs.
    
    This preserves classic semantics for string-only values, but makes the
    object values behave in a more uniform way.
    jgraham committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    59d550b View commit details
    Browse the repository at this point in the history
  2. Unconditionally return the unhandledPromptBehavior capability

    When creating a session, ensure that we always return the used value
    of this capability, whether or not it was passed in.
    jgraham committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    af51973 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Allow ignoring position or dimensions in set window rect

    Previously it was unclear if it was acceptable to return without error
    from set window rect if the implementation is unable to set some of
    the properties.
    
    This updates the spec so that:
    
    * It's unambiguously OK to run the command even if you don't support
    some aspects of the functionality on the current platform /
    configuration (you are expected to continue to return an error if you
    don't support any aspect of the functionality).
    
    * It's clear that both position and dimension properties are best
    effort, and even if you are able to adjust them there's no guarantee
    that you get the exact requested values.
    
    * It's clear what to do if you get just an x coordinate but not y, or
    just width but not height, or vice-versa. Previously this was undefined.
    jgraham committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    bb939cc View commit details
    Browse the repository at this point in the history
  2. Fix some small problems with set window rect changes (w3c#1832)

    * Fix some small problems with set window rect changes
    
    * Restore handling both missing and null values for parameters.
    
    * Fix some grammar errors.
    
    * Apply suggestions from code review
    
    ---------
    
    Co-authored-by: Alex Rudenko <[email protected]>
    jgraham and OrKoN authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    57eb5e9 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Configuration menu
    Copy the full SHA
    7a23ea0 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Configuration menu
    Copy the full SHA
    172882a View commit details
    Browse the repository at this point in the history