Initial implementation of tabs bar #1468
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeerias
force-pushed
the
felipeerias/tabs
branch
from
641b268
to
eb31be6
Compare
felipeerias
force-pushed
the
felipeerias/tabs
branch
from
eb31be6
to
22da6fa
Compare
felipeerias
force-pushed
the
felipeerias/tabs
branch
2 times, most recently
from
3756d48
to
8acbe88
Compare
felipeerias
force-pushed
the
felipeerias/tabs
branch
2 times, most recently
from
e791cfd
to
543e9bd
Compare
svillar
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Haven't reviewed the code in detail yet but I have some comments
- Do we really want to have all those possibilities to show the tabs, I think we should select the best one and stick to it. Giving users too many options is not something I think is necessarily good
- The bar in horizontal mode is wider than the window
- The bar in horizontal mode hides the top bar widget which allows you to close windows
- The vertical mode does not look good in multiwindow mode IMO, it does overlap with multiple windows
Instead of having them permanently on top, what do you think about having a small UI element that when on hovered "unrolls" the tabs bar (either vertical or horizontal)?
|
Early video, to show the feature in action: 2024-10-02-tabs.mp4 |
felipeerias
force-pushed
the
felipeerias/tabs
branch
from
543e9bd
to
af15e21
Compare
|
I have updated the PR to hide the tabs bar when the window is being resized, and also to ensure that it updates its size correctly. 2024-10-03-tabs.mp4 |
felipeerias
force-pushed
the
felipeerias/tabs
branch
2 times, most recently
from
1c3428e
to
3fccc3e
Compare
|
I have fixed the interplay between the horizontal tabs bar and the TopBarWidget. Regarding the vertical tabs bar, at the moment my idea is to simply move the unfocused window slightly to the left to make space for it. Something like this:
|
The Tabs Bar is a small window that sits next to the current window and which lists the open tabs. There are two implementations: - HorizontalTabsBar on the top of the window - VerticalTabsBar on the side of the window The Tabs Bar is managed by VRBrowserActivity. SessionStore now keeps a list of session change listeners. TabDelegate is moved to a separate interface. The current tabs style can be changed in Settings -> Display. WindowViewModel gets three new fields: - isTabsBarVisible - usesHorizontalTabsBar - usesVerticalTabsBar TopBarWidget uses two of these fields to update its placement so as to not overlap with the tabs bar. Note that we don't (yet) link windows and tabs, so the interface gets a bit confusing when we have more than one window open.
felipeerias
force-pushed
the
felipeerias/tabs
branch
from
3fccc3e
to
49e6435
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tabs Bar is a small window that sits next to the current window and which lists the open tabs.
There are two implementations in this PR:
HorizontalTabsBaron the top of the windowVerticalTabsBaron the side of the windowThe Tabs Bar is managed by
VRBrowserActivity.SessionStorenow keeps a list of session change listeners so the tabs bar can be updated.SessionChangeListenerandTabDelegateare moved to separate files.The location of tabs can be changed in Settings -> Display.
Note that Wolvic does not keep track of the relationship between windows and tabs. There is one single list of tabs that can be dynamically displayed on one or more windows. Unfortunately, this means that the interface tends to get a bit confusing when we have more than one window open.