Fix the dashed line again (but for Get WPE now) #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #188 This is basically the fix implemented in [1], which was rendered useless after PR #189 [2] got merged, so this is a quick fix. [1] #191 [2] #189 Site preview: https://igalia.github.io/wpewebkit.org/issue-188-v2
|
You caught that! I was planning to fix it as soon as #189 landed. Thumbs up from me; if you want to add me as a reviewer, I can approve and merge. |
meyerweb
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188
This is basically the fix implemented in [1], which was rendered useless after PR #189 [2] got merged, so this is a quick fix.
[1] #191
[2] #189
Site preview: https://igalia.github.io/wpewebkit.org/issue-188-v2