Add link to documentation directory in each release page #231
Conversation
|
This is how the release pages look now:
|
Add a button to the documentation directory under /reference for those releases that have it. A small JS data script adds a "hasDocumentation" computed data property to each page, which will be true in release pages for the "wpewebkit" package, from versions 2.23.90 onwards (inclusive). The version comparison is done reusing the "semver" package. Just in case there might be some release after that version that does not have documentation, the "hideDocumentation" data attribute is also honored. While at it, fix the post date being close tight to the download and documentation buttons. Instead, promote the <time> element containing the date to a block, which causes it to occupy its own "line". To avoid stealing much vertical space for the buttons, a new "btn-l" class is added, similar to "btn-xl", which produces smaller buttons.
aperezdc
force-pushed
the
aperezdc/release-doc-links
branch
from
91e80ca
to
daf5c59
Compare
|
On the GitHub site preview pages (e.g., https://igalia.github.io/wpewebkit.org/aperezdc/release-doc-links/release/wpewebkit-2.44.2.html), I’m only seeing the Download button. Is this an artifact of GH Pages builds, or was there a change since @aperezdc’s screenshot was posted? |
The previews have never worked well for this site. |
Wow, seriously — local preview works fine, so I’m working off that. The secondary-classed buttons are set to be much too low-contrast. I’ve fiddled with some variants and here are two. Please don’t think I mean we should do both: I think we should pick one or the other. (Or a third way that is better than either of these, if someone has one, such as changing a text color or some other adjustment.) Thoughts?
|
|
I do like that version better, and I would even say that different colors for documentation and download might make sense to distinguish that one will download a file, and the other open another webpage. |
I tried locally and I see the blue button invoves changing from the Do we agree on merging this PR with the addition of making the buttons blue with |
Use the .btn-primary CSS class for buttons instead of .btn-secondary, which makes them have blue background with white text. This greatly improves contrast.
Add a button to the documentation directory under
/referencefor those releases that have it. A small JS data script adds ahasDocumentationcomputed data property to each page, which will be true in release pages for thewpewebkitpackage, from versions2.23.90onwards (inclusive). The version comparison is done reusing thesemverpackage. Just in case there might be some release after that version that does not have documentation, thehideDocumentationdata attribute is also honored.While at it, fix the post date being close tight to the download and documentation buttons. Instead, promote the
<time>element containing the date to a block, which causes it to occupy its own “line”. To avoid stealing much vertical space for the buttons, a new.btn-lCSS class is added, similar to.btn-xl, which produces smaller buttons.Site preview: https://igalia.github.io/wpewebkit.org/aperezdc/release-doc-links/