Experiment with test design, using testable statements from manual core-aam tests #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the
core-aam/acacia/testable-statements/
as a temporary directory for these tests. You can see the original "bag of properties" tests in the directory "property-bag".These tests use a object that defines multiple assertions, all the assertions contained in a single table in the core-aam role and property mapping tables. The assertions are almost identical to the assertions in the "manual" core-aam tests (for example: core-aam/blockquote-manual.html. This PR also adds the logic to execute those test statements on the back end against the API and sends back an array with
PASS
orFail: <errormsg>
for each assertion.Here is the result of this test: https://spectranaut.github.io/examples/wpt/role_blockquote_test.html
Right now the test has one subtest for each API, regardless of whether or not that API applies to platform the test is being run on. The test was run on linux, so only the first test -- the test of the linux API
Atspi
-- is useful. The other tests aren't actually run (because you can't run a mac accessibility API test on linux), which you can see by expanding and seeingNo assertions run
.The design is that the test is sent to the backend, and the backend returns:
Why this awkward design that includes a few meaningless subtests each time we run the test?
tl;dr: Mostly, to be able to publish to wpt.fyi with no changes to wpt.fyi. wpt.fyi assumes that every test and every subtest is run on every browser/operating system pair, but our tests are operating system specific.
For context and to understand the alternative possible test designs, you need to know there is not a 1-1 mapping for APIs and operating systems:
So, other options for test design:
For either (1) and (2), we could have to update wpt.fyi
For (3): Unfortunately, this direction is pretty much a no-go because Windows has two accessibility APIs, and a browser might implement one or the other (or none). We need different tests or different subtests for these different APIs.