Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to choose which city to ignore from distribution of resources. #223

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

Rakkuzan
Copy link
Contributor

@Rakkuzan Rakkuzan commented Feb 3, 2024

I need the ability to choose which cities to ignore when redistributing the resources because I use a floater to farm barbarians and I don't want to move any of my resources there.

That's why I made this pull request, which adds this function.

@ElieTaillard ElieTaillard requested a review from ikagod February 3, 2024 18:37
@ElieTaillard ElieTaillard added the release notes Items are likely to be highlighted in the release notes. label Feb 3, 2024
@ElieTaillard ElieTaillard added this to the 6.7.1 milestone Feb 3, 2024
@susikaman
Copy link
Contributor

This is an excellent idea! I thought this was already suggested somewhere, but I couldn't find any ticket mentioning this though. Perhaps this could also be used in case of an error occuring for a specific town, mentioned in issue #204

Copy link
Collaborator

@ikagod ikagod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea behind this is great, and I wouldn't think of it myself because I don't use portable cities.
I feel like the tests should be fixed before this is merged though...

@Rakkuzan
Copy link
Contributor Author

Rakkuzan commented Feb 4, 2024

Sure, I will try to work on it when I have the time

@Rakkuzan
Copy link
Contributor Author

Rakkuzan commented Feb 5, 2024

Tests are fixed.

@ElieTaillard ElieTaillard merged commit 5501ab4 into Ikabot-Collective:master Feb 7, 2024
10 checks passed
@ElieTaillard ElieTaillard modified the milestones: 6.7.1, 7.0.0 Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes Items are likely to be highlighted in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants