Improve LowWine alert system #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will there be more commits made to this PR? |
|
At this time no. But until the next update to the version 7.1.0 i`ll have some updates on the module. There for this pull request is still in draft |
|
This module can be mearged to the master. Small improve to the alerted list. Modify msg when setting up the alert. |
ElieTaillard
force-pushed
the
Update-Low-wine-fix-bugs-and-improve
branch
from
5cc6ca8 to
33e20df
Compare
I have change and now the was_alerted will be clear. Added in message_log to pull the amount of wine and consumption.
ElieTaillard
added
the
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update.
Now the list with alerted city will be clear after 24h. This was needed because after first alert on one city, that city will not get alerted anymore.
Minor fix and improve of the overall code.