Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with increaseAtPos #85

Closed
wants to merge 0 commits into from
Closed

Conversation

dabates
Copy link
Contributor

@dabates dabates commented Feb 10, 2022

Reference #82

Fixes around what TEMP returns.

Talked to @brightrim about this issue, changed the function

  • Returns the new "amount"
  • Adds the update to the world so the display updates immediately

@vilarion
Copy link
Member

This is not documented correctly. increaseAtPos returns not the new number, but the number of items it was unable to create in the given slot. That being said, I am up for changing this behaviour.

  • The same change would have to be made in Character::increaseAtPos for consistency.
  • The same change would have to be made in Player::increaseAtPos for consitency and also clean up code duplication.
  • The server uses this function as well, make sure the slot update is not sent to the client twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants