Fix removed "php_strtolower" for PHP 8.4 #690
Conversation
| @@ -610,7 +610,7 @@ static zval *php_imagick_read_property(zend_object *object, zend_string *member, | |||
| if (format) { | |||
| retval = rv; | |||
| ZVAL_STRING(retval, format); | |||
| php_strtolower(Z_STRVAL_P(retval), Z_STRLEN_P(retval)); | |||
| zend_str_tolower(Z_STRVAL_P(retval), Z_STRLEN_P(retval)); | |||
There was a problem hiding this comment.
I bet it should be used conditionally depending on PHP version
| zend_str_tolower(Z_STRVAL_P(retval), Z_STRLEN_P(retval)); | |
| #if PHP_VERSION_ID < 80400 | |
| php_strtolower(Z_STRVAL_P(retval), Z_STRLEN_P(retval)); | |
| #else | |
| zend_str_tolower(Z_STRVAL_P(retval), Z_STRLEN_P(retval)); | |
| #endif |
There was a problem hiding this comment.
Other 2 places also needs this
There was a problem hiding this comment.
Why - it is present at least since PHP 5.4 - https://github.com/php/php-src/blob/PHP-5.4.45/Zend/zend_operators.h#L332
There was a problem hiding this comment.
Sorry, I didn't check php-src, looks like the function exists, so probably it's not required
|
@Danack can we get this merged? |
|
I checked the patch and it is working. One thing, though: I still use the same code to update PHP 5.3 (yeah, I know), so I had a #ifdef #else #endif construction anyway. |
|
Based on https://github.com/Imagick/imagick/blob/3.7.0/package.xml#L8 PHP 5.3 (and lower) is no longer supported. |
fixes #689
see https://github.com/php/php-src/pull/15391/files