feat: Improve protection logic #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xonramp
commented
Jan 16, 2025
0xonramp
commented
Jan 16, 2025
Comment on lines
+14
to
+21
| 'ic-ip-address': | ||
| req.headers.get('cf-connecting-ip') ?? | ||
| req.headers.get('x-forwarded-for') ?? | ||
| undefined, | ||
| 'ic-ip-country': | ||
| req.headers.get('cf-ipcountry') ?? | ||
| req.headers.get('x-vercel-ip-country') ?? | ||
| undefined, |
There was a problem hiding this comment.
Fallbacks are there so the code works on preview deployments (i.e. not passing through the cloudflare proxy)
janndriessen
approved these changes
Jan 16, 2025
tokdaniel
reviewed
Jan 17, 2025
| @@ -97,10 +103,22 @@ export function SmartTradeButton(props: SmartTradeButtonProps) { | |||
| const [warnings, setWarnings] = useState<WarningType[]>([]) | |||
|
|
|||
| useEffect(() => { | |||
| if (!isTradablePair && !hiddenWarnings?.includes(WarningType.restricted)) { | |||
| if ( | |||
There was a problem hiding this comment.
im thinking there is no effect here, so instead of an effect and a state you could just use useMemo, and return the result
There was a problem hiding this comment.
@tokdaniel good call, updated to useMemo 👍
tokdaniel
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the protection provider to leverage the new API endpoint to check for restricted countries/VPN usage, and adds new messaging for VPN users.