Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update formatted single token prices #962

Merged
merged 2 commits into from
Jan 4, 2024
Merged

update formatted single token prices #962

merged 2 commits into from
Jan 4, 2024

Conversation

janndriessen
Copy link
Collaborator

Summary of Changes

  • Updates the single token prices displayed in the trade details section to be determined by dividing the quantities

Test Data or Screenshots

Bildschirmfoto 2024-01-03 um 15 12 31
By submitting this pull request, you are confirming the following to be true:
  • I have reviewed the Contribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match the master at IndexCoop/index-app.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.

@janndriessen janndriessen requested a review from 0xonramp January 3, 2024 14:13
@vercel Vercel
Copy link

vercel bot commented Jan 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
index-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2024 2:15pm

@janndriessen janndriessen changed the title update formatted single token prices (dividing by quantity) update formatted single token prices Jan 3, 2024
0xonramp
0xonramp approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@0xonramp 0xonramp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@janndriessen janndriessen merged commit ae0d402 into feat/the-merge Jan 4, 2024
3 checks passed
@janndriessen janndriessen deleted the task/update-single-prices branch January 4, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xonramp 0xonramp 0xonramp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janndriessen @0xonramp