Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend presenting_revoked_credential example to ledger-agnostic endpoints using wallet=askar-anoncreds #169

Merged
merged 16 commits into from
Jan 24, 2025

Conversation

Athan13
Copy link

@Athan13 Athan13 commented Nov 27, 2024

No description provided.

@Athan13 Athan13 requested a review from dbluhm November 27, 2024 20:20
@Athan13 Athan13 changed the title Extend presenting_revoked_credential test to ledger-agnostic endpoints using wallet=askar-anoncreds Extend presenting_revoked_credential example to ledger-agnostic endpoints using wallet=askar-anoncreds Nov 27, 2024
@dbluhm dbluhm self-assigned this Dec 10, 2024
Copy link
Member

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Just a few suggestions to further improve the usability of these changes.

acapy_controller/protocols.py Outdated Show resolved Hide resolved
@Athan13 Athan13 force-pushed the feature/anoncreds-wallet branch from ed7e187 to aed4b51 Compare December 19, 2024 02:05
Athan Massouras added 4 commits December 18, 2024 18:31
Some minor refactors.

Signed-off-by: Athan Massouras <[email protected]>
…mple

such testing exists in presenting_revoked_credentials

Signed-off-by: Athan Massouras <[email protected]>
…dataclasses with dict elements as fields

Signed-off-by: Athan Massouras <[email protected]>
…ult and CredDefResult types for askar-anoncreds wallet

Signed-off-by: Athan Massouras <[email protected]>
@dbluhm
Copy link
Member

dbluhm commented Jan 21, 2025

Minor code formatting complaints in the format and lint check. The other tests appear to be failing because docker-compose is not found. I suspect that on the new ubuntu runner it's probably docker compose now or something. @Athan13 can you pin the runs-on clause of the actions to runs-on: ubuntu-22.04?

@Athan13
Copy link
Author

Athan13 commented Jan 24, 2025

Format checker with ruff passes:
Screenshot 2025-01-24 at 13 37 05

Copy link
Member

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@dbluhm dbluhm merged commit 7c2e96b into main Jan 24, 2025
3 of 4 checks passed
@Athan13 Athan13 deleted the feature/anoncreds-wallet branch January 26, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants