-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend presenting_revoked_credential
example to ledger-agnostic endpoints using wallet=askar-anoncreds
#169
Conversation
presenting_revoked_credential
test to ledger-agnostic endpoints using wallet=askar-anoncredspresenting_revoked_credential
example to ledger-agnostic endpoints using wallet=askar-anoncreds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! Just a few suggestions to further improve the usability of these changes.
…skar-anoncreds Signed-off-by: Athan Massouras <[email protected]>
Signed-off-by: Athan Massouras <[email protected]>
Signed-off-by: Athan Massouras <[email protected]>
Signed-off-by: Athan Massouras <[email protected]>
Signed-off-by: Athan Massouras <[email protected]>
Signed-off-by: Athan Massouras <[email protected]>
ed7e187
to
aed4b51
Compare
Some minor refactors. Signed-off-by: Athan Massouras <[email protected]>
…mple such testing exists in presenting_revoked_credentials Signed-off-by: Athan Massouras <[email protected]>
…dataclasses with dict elements as fields Signed-off-by: Athan Massouras <[email protected]>
…ult and CredDefResult types for askar-anoncreds wallet Signed-off-by: Athan Massouras <[email protected]>
Minor code formatting complaints in the format and lint check. The other tests appear to be failing because |
Signed-off-by: Athan Massouras <[email protected]>
…n github Signed-off-by: Athan Massouras <[email protected]>
Signed-off-by: Athan Massouras <[email protected]>
Signed-off-by: Athan Massouras <[email protected]>
…ncreds Signed-off-by: Athan Massouras <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
No description provided.