Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: 404 notfound page added with config #172

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

RamakrushnaBiswal
Copy link
Contributor

@RamakrushnaBiswal RamakrushnaBiswal commented Jun 25, 2024

PR Description 📜

404 notfound page added with config

Fixes #154 solved


Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added README.md in my folder

Add your screenshots(Optional) 📸

image



Thank you soo much for contributing to our repository 💗

@RamakrushnaBiswal
Copy link
Contributor Author

hi @trishanu-init please review the PR

@trishanu-init trishanu-init added level1 gssoc level1 issue gssoc Gssoc'24 Identifier labels Jun 25, 2024
@trishanu-init trishanu-init merged commit 1803db0 into Indie-Kart:main Jun 25, 2024
@RamakrushnaBiswal RamakrushnaBiswal deleted the ram-dev branch June 25, 2024 18:47
@RamakrushnaBiswal
Copy link
Contributor Author

Hi @trishanu-init can you give it label 2 I worked this type issues they give it to level 2🙏🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Gssoc'24 Identifier level1 gssoc level1 issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Creating custom 404 not found page for the website
2 participants