Explicitly set Content-Length on package upload when possible. Fixes #15

Inedo · Jan 11, 2019 · 6b921d3 · 6b921d3
1 parent a1f1bb9
commit 6b921d3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/Inedo.UPack/Net/DefaultApiTransport.cs b/src/Inedo.UPack/Net/DefaultApiTransport.cs
@@ -41,7 +41,12 @@ public override async Task<ApiResponse> GetResponseAsync(ApiRequest request, Can
 
             if (request.RequestBody != null)
             {
-                webRequest.AllowWriteStreamBuffering = false;
+                if (request.RequestBody.CanSeek)
+                {
+                    webRequest.AllowWriteStreamBuffering = false;
+                    webRequest.ContentLength = request.RequestBody.Length - request.RequestBody.Position;
+                }
+
                 using (var requestStream = await webRequest.GetRequestStreamAsync().ConfigureAwait(false))
                 {
                     await request.RequestBody.CopyToAsync(requestStream, 81920, cancellationToken).ConfigureAwait(false);

diff --git a/src/Inedo.UPack/Net/UniversalFeedClient.cs b/src/Inedo.UPack/Net/UniversalFeedClient.cs
@@ -345,7 +345,7 @@ public async Task<Stream> GetPackageFileStreamAsync(UniversalPackageId id, Unive
         /// <summary>
         /// Uploads the package in the specified stream to the feed.
         /// </summary>
-        /// <param name="stream">Stream containg a universal package.</param>
+        /// <param name="stream">Stream containing a universal package.</param>
         /// <param name="cancellationToken">Cancellation token for asynchronous operations.</param>
         /// <exception cref="ArgumentNullException"><paramref name="stream"/> is null.</exception>
         public async Task UploadPackageAsync(Stream stream, CancellationToken cancellationToken)