Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-output-target test #1509

Closed
wants to merge 3 commits into from
Closed

react-output-target test #1509

wants to merge 3 commits into from

Conversation

akashyeole
Copy link
Member

@akashyeole akashyeole commented Sep 30, 2024

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
Provide the information we need to review your PR. What problem does the pull request solve? "Bug fix" is not a good description.

Related Issue
If you opened an issue before creating the PR, point to it here.

Context
What do we need to know about your development environment, tools, target, and so on. Screenshots are always helpful if there is a UI element to this PR.

📦 Published PR as canary version: 25.2.2--canary.1509.67f2210e7e14765ab19e8c19b801c71922d85d9c.0

✨ Test out this PR locally via:

npm install @infineon/infineon-design-system-stencil@25.2.2--canary.1509.67f2210e7e14765ab19e8c19b801c71922d85d9c.0
# or 
yarn add @infineon/infineon-design-system-stencil@25.2.2--canary.1509.67f2210e7e14765ab19e8c19b801c71922d85d9c.0

Copy link
Contributor

github-actions bot commented Sep 30, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://Infineon.github.io/infineon-design-system-stencil/pr-preview-vue-example/pr-1509/
on branch gh-pages at 2024-09-30 09:23 UTC

Copy link
Contributor

--STORYBOOK-PREVIEW--

@verena-ifx
Copy link
Contributor

can you provide details about this issue? the react output target was fixed already

@akashyeole
Copy link
Member Author

@verena-ifx
The issue #1457 is still open.
I also get error when I try to run the react app in PR #1416 (IfxSegmentedControl was not found in '@infineon/infineon-design-system-react').

@verena-ifx
Copy link
Contributor

hmmm are you using react-vite-javascript app?
the react-javascript folder is still in there, but it is not working since the latest upgrade of the react-output-target, as react-scripts (used here as build tool) is outdated and doesnt align with that latest react-output-target update, as it seems.
So for the example apps, i have now set react-vite-javascript as the folder that is deployed to github-pages.

@akashyeole
Copy link
Member Author

@verena-ifx
It didn't work in react+vite as well. But I will merge master and try again.

@akashyeole akashyeole closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants