Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Use artifact v4 instead of v3 #2224

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CI: Use artifact v4 instead of v3 #2224

wants to merge 1 commit into from
+7 −7

Conversation

jmlich
Copy link
Contributor

@jmlich jmlich commented Jan 10, 2025 •
edited
Loading

It seems v3 can be directly replaced by v4.

I have seen just issue with naming infinitisim artifact, which is unrelated with migration to v4. See #2223

@github-actions GitHub Actions
Copy link

Build size and comparison to main:

Section Size Difference
text 372944B 0B
data 948B 0B
bss 22536B 0B

@jmlich jmlich changed the title Fixes #2219: use artifact v4 instead of v3 CI: Use artifact v4 instead of v3 Jan 10, 2025
@mark9064 mark9064 added the maintenance Background work label Jan 10, 2025
mark9064
mark9064 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@mark9064 mark9064 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only glanced at the changes but it seems to be about functionality we don't use. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark9064 mark9064 mark9064 approved these changes

Assignees
No one assigned
Labels
maintenance Background work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmlich @mark9064