Rf scratch #3
Open
Rf scratch #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DWVoid
reviewed
Dec 18, 2019
Src/GameConnection.hpp
Outdated
| @@ -3,15 +3,52 @@ | |||
| #include <memory> | |||
| #include <vector> | |||
| #include "Object.hpp" | |||
|
|
|||
| #include "Windows.hpp" | |||
There was a problem hiding this comment.
The presence of the Windows.h include in headers will cause significant compile slow-down to all relevant files.
DWVoid
reviewed
Dec 18, 2019
Src/GameConnection.hpp
Outdated
| virtual void getMousePosition(Vec2d& pos)noexcept = 0; | ||
| virtual PlayerState GetPlayerStateInformation()noexcept = 0; | ||
| }; | ||
| class GameConnectionTH10 : public GameConnection { |
There was a problem hiding this comment.
Implementation details of a unit should not be put in headers resembling an internal interface. Move it to CPP files instead.
DWVoid
reviewed
Dec 18, 2019
Src/GameConnection.hpp
Outdated
| void sendKeyInfo(int dir, bool shift, bool z, bool x) noexcept override; | ||
| void getMousePosition(Vec2d& pos)noexcept override; | ||
| int getTimeline() noexcept override; | ||
| PlayerState GetPlayerStateInformation()noexcept override; |
There was a problem hiding this comment.
Please apply naming conventions consistently if you decide to make any changes to that
DWVoid
reviewed
Dec 18, 2019
Src/KeyboardManager.cpp
Outdated
| @@ -12,7 +12,7 @@ namespace { | |||
| constexpr const char KEY_X = 88; | |||
| constexpr const char KEY_Z = 90; | |||
| constexpr const char KEY_ESCAPE = 90; | |||
| void sendKey(int key, bool down) noexcept { | |||
| void sendKey(int key, bool down) noexcept { | |||
DWVoid
reviewed
Dec 18, 2019
Src/bmpCreater.hpp
Outdated
| #include <cstdlib> | ||
| #include <cstring> | ||
| #include <Windows.h> | ||
| /* |
There was a problem hiding this comment.
Same problem as above. You should NOT use windows-only APIs when the content can be easily implemented with ISO C++ contents.
DWVoid
reviewed
Dec 18, 2019
| pauseUntilPress("�뽫������ڷ���¼�����ϣ���ʼ��Ϸ��Ȼ��C����AI", 'C'); | ||
| std::cout << "�ѿ�ʼ��Ϸ����P���ӡ���ͼ��Q���˳�" << std::endl; | ||
| pauseUntilPress("�뽫������ڷ���¼�����ϣ���ʼ��Ϸ����C����AI", 'C'); | ||
| std::cout << "�ѿ�ʼ��Ϸ����C����/�ر������Q���˳�" << std::endl; | ||
| unsigned long long frameCount = 0; | ||
| StopWatch watch; | ||
| int mapOutputCount = 0; |
DWVoid
requested changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.