Progress Bar: Adjusted bar height control placement and labels

- Moved bar height control outside the conditional block to make it available for all progress bar types - Simplified "Progress bar height" label to "Bar height"
Infinite-Null · Jan 27, 2025 · 514375f · 514375f
1 parent cd80082
commit 514375f
Showing 1 changed file with 24 additions and 21 deletions.
diff --git a/packages/block-library/src/progress-bar/edit.js b/packages/block-library/src/progress-bar/edit.js
@@ -155,27 +155,30 @@ export default function Edit( { attributes, setAttributes } ) {
 									}
 								/>
 							</ToolsPanelItem>
-							<ToolsPanelItem
-								label={ __( 'Progress bar height' ) }
-								isShownByDefault
-								hasValue={ () => height !== 11 }
-								onDeselect={ () =>
-									setAttributes( { height: 11 } )
-								}
-							>
-								<RangeControl
-									__next40pxDefaultSize
-									__nextHasNoMarginBottom
-									label={ __( 'Progress bar height' ) }
-									help={ __( 'Height in pixels' ) }
-									value={ height }
-									onChange={ ( heightValue ) =>
-										setAttributes( { height: heightValue } )
-									}
-									min={ 1 }
-									max={ 30 }
-								/>
-							</ToolsPanelItem>
+						</>
+					) }
+					<ToolsPanelItem
+						label={ __( 'Bar height' ) }
+						isShownByDefault
+						hasValue={ () => height !== 11 }
+						onDeselect={ () => setAttributes( { height: 11 } ) }
+					>
+						<RangeControl
+							__next40pxDefaultSize
+							__nextHasNoMarginBottom
+							label={ __( 'Bar height' ) }
+							help={ __( 'Height in pixels' ) }
+							value={ height }
+							onChange={ ( heightValue ) =>
+								setAttributes( { height: heightValue } )
+							}
+							min={ 1 }
+							max={ 30 }
+						/>
+					</ToolsPanelItem>
+
+					{ ! isReadProgress && (
+						<>
 							<ToolsPanelItem
 								label={ __( 'Show value' ) }
 								isShownByDefault