feat: Compute snooze state in thread #2218
Open
+55
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
KevinBoulongne
requested changes
Mar 6, 2025
Comment on lines
+23
to
+25
| Snoozed(apiValue = "snoozed"), | ||
| Unsnoozed(apiValue = "unsnoozed"), | ||
| WasSnoozed(apiValue = "was_snoozed"), |
There was a problem hiding this comment.
Maybe add some short comment explaining what each state represents exactly.
| } | ||
|
|
||
| private fun updateThread() { | ||
|
|
||
| fun Thread.updateSnoozeSatesBasedOn(message: Message) { |
There was a problem hiding this comment.
Suggested change
| fun Thread.updateSnoozeSatesBasedOn(message: Message) { | |
| fun Thread.updateSnoozeStateBasedOn(message: Message) { |
Comment on lines
+236
to
238
| duplicates.forEach { duplicate -> | ||
| updateSnoozeSatesBasedOn(duplicate) | ||
| } |
There was a problem hiding this comment.
Suggested change
| duplicates.forEach { duplicate -> | |
| updateSnoozeSatesBasedOn(duplicate) | |
| } | |
| duplicates.forEach(::updateSnoozeSatesBasedOn) |
Comment on lines
+236
to
238
| duplicates.forEach { duplicate -> | ||
| updateSnoozeSatesBasedOn(duplicate) | ||
| } |
There was a problem hiding this comment.
Do we really need/want to update the Thread based on the duplicated Messages ? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply computes the snooze state at the thread level and can directly be merged inside master as it's not even visible to the user