Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ReviewManager #183

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Add ReviewManager #183

wants to merge 3 commits into from

Conversation

Matthieu-dgl
Copy link
Contributor

@Matthieu-dgl Matthieu-dgl self-assigned this Mar 4, 2025
Copy link

github-actions bot commented Mar 4, 2025

Found 1 unused code occurences

Expand
SwissTransferFeatures/MainView/MainView.swift:37:41: warning: Property 'openURL' is unused

@Matthieu-dgl Matthieu-dgl force-pushed the feat/add-review-manager branch from 6756eef to 0e7a2fd Compare March 4, 2025 06:23
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first quick review, I'll review it fully when the core PR is merged

@@ -45,6 +52,11 @@ public struct MainView: View {
}
.sceneLifecycle(willEnterForeground: willEnterForeground)
.environmentObject(mainViewState.transferManager)
.onAppear {
if UserDefaults.shared.transferCount == 2 && !UserDefaults.shared.hasReviewedApp {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can declare a named constant for 2

@Matthieu-dgl Matthieu-dgl force-pushed the feat/add-review-manager branch from 0e7a2fd to f49d33d Compare March 5, 2025 08:32
@github-actions github-actions bot removed the dependent label Mar 5, 2025
Copy link

github-actions bot commented Mar 5, 2025

This PR/issue depends on:

Copy link

sonarqubecloud bot commented Mar 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants