-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ReviewManager #183
base: main
Are you sure you want to change the base?
Conversation
Found 1 unused code occurences Expand
|
6756eef
to
0e7a2fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a first quick review, I'll review it fully when the core PR is merged
@@ -45,6 +52,11 @@ public struct MainView: View { | |||
} | |||
.sceneLifecycle(willEnterForeground: willEnterForeground) | |||
.environmentObject(mainViewState.transferManager) | |||
.onAppear { | |||
if UserDefaults.shared.transferCount == 2 && !UserDefaults.shared.hasReviewedApp { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can declare a named constant for 2
0e7a2fd
to
f49d33d
Compare
This PR/issue depends on:
|
|
Depends on Infomaniak/ios-core-ui#89