Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show not inline files #1689

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lebojo
Copy link
Contributor

@lebojo lebojo commented Mar 5, 2025

Display non inline attachments files even with contentId

Copy link

sonarqubecloud bot commented Mar 5, 2025

Copy link

github-actions bot commented Mar 5, 2025

Found 0 unused code occurences

Expand
* No unused code detected.

Copy link
Member

@PhilippeWeidmann PhilippeWeidmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a computed property so this will be on the main thread.

What we should do is do this computation once when we get the message here: MailboxManager+Message.swift:26 (and also update the corresponding thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants