feat: Support copy-free upload #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirambd
requested changes
Mar 3, 2025
...e/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/managers/UploadManager.kt
Outdated
Show resolved
Hide resolved
...e/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/managers/UploadManager.kt
Outdated
Show resolved
Hide resolved
STCore/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/SharedApiUrlCreator.kt
Outdated
Show resolved
Hide resolved
...re/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/data/NewUploadSession.kt
Show resolved
Hide resolved
...ommonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/network/utils/SharedApiRoutes.kt
Outdated
Show resolved
Hide resolved
...e/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/managers/UploadManager.kt
Outdated
Show resolved
Hide resolved
This commit adds new functions in UploadManager that will allow uploading directly, without relying on a persisted upload session and copied files. This is required to avoid filling the device's storage to starvation of free space when creating a transfer with big files.
LouisCAD
force-pushed
the
copy-free-upload
branch
2 times, most recently
from
5832897 to
5c55b7c
Compare
LouisCAD
force-pushed
the
copy-free-upload
branch
from
c792bfa to
b5ab86f
Compare
sirambd
requested changes
Mar 4, 2025
...mmonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/managers/InMemoryUploadManager.kt
Outdated
Show resolved
Hide resolved
…ager This separates DB session reliant functions from the ones that don't need it.
LouisCAD
force-pushed
the
copy-free-upload
branch
from
b5ab86f to
29b4182
Compare
|
sirambd
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new functions in UploadManager that will allow uploading directly, without relying on a persisted upload session and copied files.
This is required to avoid filling the device's storage to starvation of free space when creating a transfer with big files.
I successfully tested it locally with changes in the Android app.