Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows support #34

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from
Open

Conversation

wnhrt
Copy link

@wnhrt wnhrt commented Aug 13, 2021

Known issues:

  • can only handle single char input (no arrows, ctrl-KEY or alt-KEY)
  • does not resize on size change of window
  • no support for variable length unicode symbols

@IngoMeyer441
Copy link
Owner

Thanks for the great job to fix #5. 👍
I think I will first separate the existing code into a terminal dependent (→ backend) and independent part to avoid all the if/else blocks and perhaps I can find some solutions to the remaining limitations. Would be great to have arrow key support, since I don't think that everyone is used to vi motions. 😊

@wnhrt
Copy link
Author

wnhrt commented Aug 15, 2021

No problem :) I hope this helps to adapt the code for Windows.
Separating the code sounds like a very good idea. Looking forward to your implementations.

Regarding arrow support, this is the best I could came up with, without using external dependencies. But still no modifier keys.
I tried to implement it with Windows legacy code from kernel32.dll and user32.dll, but had no success.

@wnhrt
Copy link
Author

wnhrt commented Aug 16, 2021

Heureka! Here are two possible solutions, which both use the Windows API:

  • input
  • resize event (historically CMD.exe only reacts on horizontal change, 'Windows Terminal' on both axes)

@LoaiDev
Copy link

LoaiDev commented Nov 15, 2022

any updates on this?

@IngoMeyer441
Copy link
Owner

Not yet. I started to work on integrating the changes, but switched to other tasks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants