Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F/denom fix injective testing #242

Closed
wants to merge 2 commits into from
Closed

F/denom fix injective testing #242

wants to merge 2 commits into from

Conversation

maxrobot
Copy link
Contributor

@maxrobot maxrobot commented Sep 2, 2024 •
edited by coderabbitai bot
Loading

See changelog

Summary by CodeRabbit

  • New Features

    • Version 1.1.2 released, improving accuracy in financial data handling related to denominators.

  • Bug Fixes

    • Fixed incorrect denominators affecting calculations, enhancing reliability in the system.
    • Refined decimal handling for spot markets, targeting specific improvements.

  • Chores

    • Updated version number for the injective-testing package to reflect new releases.
    • Streamlined code by replacing hardcoded strings with predefined constants for better maintainability.

@maxrobot maxrobot requested a review from jbernal87 September 2, 2024 14:50
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Sep 2, 2024 •
edited
Loading

Walkthrough

The changes include updates to the injective-testing package, specifically versions 1.1.1 and 1.1.2, released on August 30, 2024. These versions address issues with denominators, particularly in calculations and spot markets. Additionally, the base denomination constant in the mock setup was changed, and hardcoded strings in the exchange.rs file were replaced with constants for better maintainability.

Changes

File Change Summary
packages/injective-testing/CHANGELOG.md Updated changelog for versions 1.1.1 and 1.1.2, detailing fixes for incorrect denominators.
packages/injective-testing/Cargo.toml Updated version number from 1.1.0 to 1.1.2.
packages/injective-testing/src/mocks.rs Changed MOCK_BASE_DENOM from "ubase" to "inj".
packages/injective-testing/src/test_tube/exchange.rs Replaced hardcoded strings with constants for denominators in various functions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Exchange
    participant Mocks

    User->>Exchange: Launch Market
    Exchange->>Mocks: Use MOCK_BASE_DENOM
    Mocks-->>Exchange: Return "inj"
    Exchange->>User: Market Launched
Loading

🐇
In the meadow, changes bloom,
With "inj" now, there's more room.
Constants guide the way we play,
No more strings to lead astray.
Hops of joy, the code's refined,
In our burrow, peace of mind! 🌼

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
Early access features: disabled

We are currently testing the following features in early access:

  • Anthropic claude-3-5-sonnet for code reviews: Anthropic claims that the new Claude model has stronger code understanding and code generation capabilities than their previous models. Note: Our default code review model was also updated late last week. Please compare the quality of the reviews between the two models by toggling the early access feature.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues on the discussion post.

coderabbitai[bot]
coderabbitai bot reviewed Sep 2, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b442784 and 2d67326.

Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
Files selected for processing (4)
  • packages/injective-testing/CHANGELOG.md (1 hunks)
  • packages/injective-testing/Cargo.toml (1 hunks)
  • packages/injective-testing/src/mocks.rs (1 hunks)
  • packages/injective-testing/src/test_tube/exchange.rs (8 hunks)
Files skipped from review due to trivial changes (1)
  • packages/injective-testing/Cargo.toml
Additional comments not posted (8)
packages/injective-testing/CHANGELOG.md (2)

8-12: LGTM!

The changelog entry for version 1.1.2 is clear and concise. It documents a specific fix related to decimals used as denoms in spot markets, which likely improves the accuracy of calculations or representations in that functionality.

14-18: LGTM!

The changelog entry for version 1.1.1 is clear and concise. It documents a general fix for incorrect denoms, which likely addresses a prior issue affecting calculations or representations in the system. This change enhances the accuracy and reliability of the system's handling of financial data related to denoms.

packages/injective-testing/src/mocks.rs (1)

16-16: Verify the impact of changing the base denomination.

The base denomination used in the mock setup is changed from "ubase" to "inj". This is a semantically significant change.

Please verify that this change does not break any functionality relying on this constant. Run the following script to search for the usage of MOCK_BASE_DENOM in the codebase and review the results:

packages/injective-testing/src/test_tube/exchange.rs (5)

2-2: LGTM!

The changes to the mocks import statement are approved.

438-439: LGTM!

The changes to replace the hardcoded string literals with constants in the launch_spot_market function are approved.

457-458: LGTM!

The changes to replace the hardcoded string literals with constants in the launch_spot_market_atom function are approved.

503-505: LGTM!

The changes to replace the hardcoded string literals with constants in the launch_perp_market function are approved.

529-531: LGTM!

The changes to replace the hardcoded string literals with constants in the launch_perp_market_atom function are approved.

jbernal87
jbernal87 approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@jbernal87 jbernal87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@maxrobot maxrobot closed this Oct 9, 2024
@maxrobot maxrobot deleted the f/denom-fix-injective-testing branch October 9, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@jbernal87 jbernal87 jbernal87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxrobot @jbernal87